-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump pyathena and related packages #21958
Conversation
There were some unexpected changes when running pip-compile-multi --no-upgrade on this. It looks like it is updating some of your recent changes here @betodealmeida. Any thoughts? |
Codecov Report
@@ Coverage Diff @@
## master #21958 +/- ##
==========================================
+ Coverage 66.89% 66.92% +0.03%
==========================================
Files 1805 1805
Lines 69055 69117 +62
Branches 7366 7366
==========================================
+ Hits 46197 46260 +63
+ Misses 20956 20955 -1
Partials 1902 1902
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# wtforms-json | ||
slack_sdk==3.18.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did something change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _
for -
. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good eye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Rant: I always cringe at the fact that -
and _
can be used interchangeably for Python deps.. 😡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, bumping always makes me feel warm and fuzzy inside! 😄 LGTM with a few non-blocking comments
# wtforms-json | ||
slack_sdk==3.18.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Rant: I always cringe at the fact that -
and _
can be used interchangeably for Python deps.. 😡
(cherry picked from commit efefb66)
🏷️ preset:2022.43 |
SUMMARY
Bumping pyathena and adding in the relevant pandas requirements for that package in order to use the schema
pyathena+pandas
which was introduced in 2.0. Typing-extensions was also bumped to 4.x for compatibility with other packages.TESTING INSTRUCTIONS
Creating and running dbs with both rest and pandas drivers for pyathena should now work
ADDITIONAL INFORMATION