-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Move dashboard auto refresh intervals options to config #21924
feat(dashboard): Move dashboard auto refresh intervals options to config #21924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21924 +/- ##
===========================================
- Coverage 66.82% 55.42% -11.41%
===========================================
Files 1805 1807 +2
Lines 69070 69197 +127
Branches 7373 7402 +29
===========================================
- Hits 46159 38354 -7805
- Misses 21005 28932 +7927
- Partials 1906 1911 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work and looks like it is aligned with a general frontend config approach e.g. https://github.com/apache/superset/search?q=DASHBOARD_AUTO_REFRESH_MODE
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
Outdated
Show resolved
Hide resolved
…l.tsx Co-authored-by: Michael S. Molina <[email protected]>
…l.tsx Co-authored-by: Michael S. Molina <[email protected]>
…l.tsx Co-authored-by: Michael S. Molina <[email protected]>
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
Outdated
Show resolved
Hide resolved
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://54.244.1.135:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the improvements and for addressing the comments @zhaorui2022
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The original dashboard auto-fresh intervals were hard-coded. However, based on the back-end query engine architecture, some options might not work. Move these options to config file so that they can be customized.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
With default option, there is no change on the UI. Tested with customized options in config file.
Google.Chrome.-.COVID.Vaccine.Dashboard.-.2022-10-24.at.2.44.22.PM.mp4
Also verified the auto refresh function is still working as expected.
TESTING INSTRUCTIONS
If testing with original options, no change is needed. Otherwise, change the options in the config file. Run
docker-compose up
and then view auto refresh options in any dashboard.ADDITIONAL INFORMATION