fix: Fix Cypress test broken by extra dashboards #21915
Conversation
codyml
force-pushed
the
fix/cypress-dashboards
branch
from
698931f to
dc2f0ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #21915 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 1807 1807
Lines 69141 69141
Branches 7394 7394
=======================================
Hits 45291 45291
Misses 21940 21940
Partials 1910 1910
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| after(() => { | ||
| cy.visit(DASHBOARD_LIST); | ||
| cy.wait(1000); | ||
| toggleBulkSelect(); | ||
| cy.wait(1000); | ||
| cy.getBySel('table-row').each($row => { | ||
| if ($row.text().indexOf('Sample dashboard') > -1) { | ||
| cy.wrap($row).find('input[type="checkbox"]').click(); | ||
| } | ||
| }); | ||
| cy.getBySel('bulk-select-action').eq(0).contains('Delete').click(); | ||
| confirmDelete(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@codyml There is a utils that it seems to do this is cy.deleteDashboard(id: number, failOnStatusCode: boolean) or deleteDashboardByName(dashboardName: string, failOnStatusCode: boolean).
Sounds good, closing in favor of #21921! |
SUMMARY
The Cypress test
chart_list/list.test.ts> Charts list > Cross-referenced dashboards adds new dashboards but doesn't remove them, causingdashboard_list/list.test.tsto fail when testing sort order if the two test files end up run on the same worker/machine. This PR adds anafterclause that removes those dashboards, and also adds awaitthat I think should help with makingchart_list/list.test.tsless flaky.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
chart_list/list.test.tsfollowed bydashboard_list/list.test.ts. There shouldn't be any errors.ADDITIONAL INFORMATION