-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect chart cache timeout setting #21637
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21637 +/- ##
===========================================
- Coverage 66.82% 55.45% -11.38%
===========================================
Files 1797 1797
Lines 68753 68765 +12
Branches 7325 7325
===========================================
- Hits 45944 38132 -7812
- Misses 20934 28758 +7824
Partials 1875 1875
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ok
…------------------ 原始邮件 ------------------
发件人: "apache/superset" ***@***.***>;
发送时间: 2022年9月29日(星期四) 下午2:28
***@***.***>;
***@***.***>;
主题: Re: [apache/superset] fix: respect chart cache timeout setting (PR #21637)
@villebro commented on this pull request.
In superset/common/query_context.py:
> @@ -46,6 +47,7 @@ class QueryContext: enforce_numerical_metrics: ClassVar[bool] = True datasource: BaseDatasource + slice_id: Optional[int] = None
..I'm assuming this should be slice: Optional[Slice]?
⬇️ Suggested change - slice_id: Optional[int] = None + slice: Optional[Slice] = None
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the added tests 👍
SUMMARY
fixes: #21635
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
start redis locally, and setup redis cache in config for data
create any chart on 1 dataset
set dataset cache timeout to 120 seconds
set chart cache timeout to 20 seconds (from properties modal).
open chart, and click on update chart
use redis cli, to check the expiry set on the cache key using ttl {cache_key} -> ishould be around 20 seconds.
after 20 seconds, click on update chart -> should not show
cached
tag on top right corner.ADDITIONAL INFORMATION