[slices axis] fix axis spacing on dashboard and explore slices #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
…e#2145) * fix axis label size bug and accommodate dual axis chart * don't adjust margins for bar time series * handling this below now * apply different margin padding if explore or dashboard * fix linting
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug where we weren't finding the axis labels for that slice, but for all slices on the page. fixed my constraining to look inside the slice container only.
adjusted additional padding based on if it's the explore view or dashboard view
i created an NVD3 Dashboard locally to test this, but will also test with a number of dashboards and slices on staging to make sure things are looking good.
before:
after:
plz review @airbnb/superset-reviewers