Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception when date range is wrong #2141

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Feb 9, 2017

Issue: https://github.com/airbnb/superset/issues/2112

Since we are moving front end to react, it makes more sense to replace flasher alerts with exceptions, ChartContainer component will display the exception error

@mistercrunch

@mistercrunch mistercrunch merged commit 236ca49 into apache:deprecate_v1 Feb 10, 2017
@yileic
Copy link
Contributor

yileic commented Feb 15, 2017

For those that needs a warning message but not raising an Exception, what's a good way to do it if not using flasher? Thank you very much for your attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants