-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds MetadataBar to Drill to Detail modal #21343
feat: Adds MetadataBar to Drill to Detail modal #21343
Conversation
* To extend the list of content types, a developer needs to request the inclusion of the new type in the design system. | ||
* This process is important to make sure the new type is reviewed by the design team, improving Superset consistency. | ||
*/ | ||
const MetadataBar = ({ items }: MetadataBarProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved the component. No code changes.
looks good, thank you @michael-s-molina! 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #21343 +/- ##
==========================================
+ Coverage 66.44% 66.54% +0.10%
==========================================
Files 1786 1791 +5
Lines 68267 68502 +235
Branches 7263 7308 +45
==========================================
+ Hits 45357 45587 +230
+ Misses 21041 21030 -11
- Partials 1869 1885 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick first pass. Thanks for the new feature.
superset-frontend/src/dashboard/components/DrillDetailPane/DrillDetailPane.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/DrillDetailPane/DrillDetailPane.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Adds
MetadataBar
to Drill to Detail modal:MetadataBar
code outside ofindex.tsx
PS: Row count is outside the scope of this PR because it needs bigger changes to the API and it will be handled in its own PR.
@kasiazjc @codyml
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-09-06.at.8.56.29.AM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION