fix(sqllab): missing zero values while copy-to-clipboard #21153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since JS returns false for zero values, following value existence statement
data[i][key]
skips the zero values.superset/superset-frontend/src/utils/common.js
Lines 100 to 106 in 0bf4e56
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
copy-to-clipboard-for-zeros.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION