-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-handlebars): Sort-By and Sort-By-Descending control not work #21005
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21005 +/- ##
==========================================
- Coverage 66.34% 66.34% -0.01%
==========================================
Files 1767 1767
Lines 67312 67313 +1
Branches 7144 7144
==========================================
Hits 44656 44656
- Misses 20828 20830 +2
+ Partials 1828 1827 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
/testenv up |
I have a handlebars chart I'll test this with asap... |
@rusackas Ephemeral environment spinning up at http://35.162.149.229:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit e70699f)
(cherry picked from commit e70699f)
SUMMARY
This PR fixes the problem that sort-by control not working in the handlebar chart.
normalizeOrderBy
to normalize the value of sort-by controlBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-08-07.10.35.18.mov
after
2022-08-07.10.33.15.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION