-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969
fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20969 +/- ##
==========================================
+ Coverage 66.34% 66.37% +0.03%
==========================================
Files 1767 1767
Lines 67312 67271 -41
Branches 7144 7147 +3
==========================================
- Hits 44656 44653 -3
+ Misses 20828 20790 -38
Partials 1828 1828
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@michael-s-molina @kgabryje @lyndsiWilliams @hughhhh Can you review it? |
/testenv up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works great! Thank you for fixing that
@kgabryje Ephemeral environment spinning up at http://34.220.145.169:8080. Credentials are |
/testenv down |
) (cherry picked from commit 6f3a555)
…che#20969) (cherry picked from commit 6f3a555)
Fix wrong scroll behaviour in
CHARTS
tab on DashboardBuilderBEFORE
Screen.Recording.2022-08-04.at.10.32.11.mov
AFTER
Screen.Recording.2022-08-04.at.10.30.34.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
@michael-s-molina @kgabryje @lyndsiWilliams