Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix nvd3 tooltips #2096

Merged
merged 3 commits into from
Feb 2, 2017
Merged

Conversation

ascott
Copy link

@ascott ascott commented Feb 2, 2017

  • hide tooltips on scroll
  • hide tooltips before re-rendering

fixes:
#2043
#2053

plz review @airbnb/superset-reviewers

@mistercrunch
Copy link
Member

LGTM

@ascott ascott changed the title Alanna fix nvd3 tooltips [dashboard] fix nvd3 tooltips Feb 2, 2017
@ascott ascott merged commit 543c22b into apache:master Feb 2, 2017
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
* hide tooltips on scroll

* hide tooltips on render/re-render of the chart

* move function above vis function, fixes linter
@hajdbo hajdbo mentioned this pull request Oct 26, 2018
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants