Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Applitools logo to the docs homepage #20917

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Jul 29, 2022

SUMMARY

Adds the Applitools logo and URL in the docs homepage

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2022-07-29 at 18 19 42

TESTING INSTRUCTIONS

  1. Open the docs
  2. Make sure the Applitools logo is showing at the bottom
  3. Make sure it works well in different screen sizes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

@kasiazjc looks good to me if it looks good to you (and any other concerned designers)

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #20917 (89dbb37) into master (90460f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20917   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1758     1758           
  Lines       67008    67008           
  Branches     7107     7107           
=======================================
  Hits        44437    44437           
  Misses      20749    20749           
  Partials     1822     1822           
Flag Coverage Δ
hive 53.25% <ø> (ø)
javascript 52.00% <ø> (ø)
mysql 81.00% <ø> (ø)
postgres 81.07% <ø> (ø)
presto 53.15% <ø> (ø)
python 81.55% <ø> (ø)
sqlite 79.67% <ø> (ø)
unit 50.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@geido geido merged commit 06d0539 into master Jul 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/add-applitools-logo branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants