-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): datatable crash when dimension is empty #20680
fix(explore): datatable crash when dimension is empty #20680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
Thanks for your contribution! cc @zhaoyongjie @kgabryje |
Thanks for the fix! Could you please write a more descriptive comment for this? |
8a8f764
to
459b313
Compare
Oops, of course! Must have fallen asleep before finishing my change 😄 |
Codecov Report
@@ Coverage Diff @@
## master #20680 +/- ##
==========================================
- Coverage 66.85% 66.85% -0.01%
==========================================
Files 1753 1753
Lines 65825 65826 +1
Branches 7006 7007 +1
==========================================
Hits 44010 44010
Misses 20030 20030
- Partials 1785 1786 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes apache#20679 Co-authored-by: Usiel Riedl <[email protected]> (cherry picked from commit 19247cc)
Fixes #20679
SUMMARY
react-table
wants every column to have a non-empty ID (or Header), else it will crash. So we simply use the current index as a fallback. From what I can see this has no side effects.Previously fixed with #17303
Reintroduced with #18569
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: https://d.pr/i/KQMrPe
After: https://d.pr/i/2qWjaq
TESTING INSTRUCTIONS
See #20679.
ADDITIONAL INFORMATION