fix: X Axis should be called Y Axis when using the Bar Chart V2 on Horizontal mode #20659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If the feature flag
GENERIC_CHART_AXES
is enabled, the Time-Series Bar Char v2 becomes Bar Chart v2 and has a field named X-Axis. However, if the Bar Chart is configured on horizontal mode, the X-Axis should be re-named to Y-Axis.This PR expands the type for the control label & description to be computed, and then does so for the above scenario.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-07-08.at.18.23.41.mov
After:
new.mov
TESTING INSTRUCTIONS
GENERIC_CHART_AXES
featureVehicle Sales
Dataset, and the Bar Chart v2.count(*)
on the Metrics, andproduct_line
on the X-Axis field.Ensure the label changes accordingly.
ADDITIONAL INFORMATION