Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect translations in Chinese in messages.po #20405

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix: Incorrect translations in Chinese in messages.po #20405

merged 1 commit into from
Jun 16, 2022

Conversation

chuancyzhang
Copy link
Contributor

SUMMARY

Chinese translation and English translation do not match

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

image

AFTER

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20405 (9c194b3) into master (1665403) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20405      +/-   ##
==========================================
+ Coverage   66.67%   66.68%   +0.01%     
==========================================
  Files        1739     1739              
  Lines       65135    65135              
  Branches     6897     6897              
==========================================
+ Hits        43427    43437      +10     
+ Misses      19955    19945      -10     
  Partials     1753     1753              
Flag Coverage Δ
hive 53.70% <ø> (ø)
mysql ?
postgres 82.36% <ø> (?)
presto 53.56% <ø> (ø)
python 82.74% <ø> (+0.03%) ⬆️
sqlite 82.09% <ø> (ø)
unit 50.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
superset/models/core.py 88.43% <0.00%> (-0.73%) ⬇️
superset/views/core.py 76.88% <0.00%> (-0.46%) ⬇️
superset/databases/api.py 95.49% <0.00%> (+0.32%) ⬆️
superset/reports/commands/execute.py 91.60% <0.00%> (+0.36%) ⬆️
superset/views/base_api.py 98.38% <0.00%> (+0.40%) ⬆️
superset/common/query_object.py 95.26% <0.00%> (+0.52%) ⬆️
superset/commands/importers/v1/utils.py 93.50% <0.00%> (+1.29%) ⬆️
superset/databases/commands/validate_sql.py 94.00% <0.00%> (+2.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1665403...9c194b3. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@michael-s-molina michael-s-molina merged commit 11d94ce into apache:master Jun 16, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants