-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cache warmup unable to login (#9597, #18933) #20387
base: master
Are you sure you want to change the base?
Conversation
c17d9c1
to
200e3d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20387 +/- ##
==========================================
- Coverage 66.70% 66.69% -0.02%
==========================================
Files 1739 1739
Lines 65137 65121 -16
Branches 6897 6897
==========================================
- Hits 43452 43433 -19
- Misses 19932 19935 +3
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm going to mention maintainers randomly due to pending reviews. Any feedback is welcome. |
Closed because of #21076 |
#21076 (comment) |
Some one please when this fix will be released? |
Wow, sorry this slid under so many people's radar for so long. This PR is in need of a rebase if you're still willing to do that, but I'll add some reviewers for good measure in case anyone is able/willing to assess the situation and carry any necessary work forward. |
This PR is still badly in need of a rebase, but I still hope we can get it across the finish line. I'll move it to Draft mode for now, but @ensky please mark it as "ready for review" if/when it is ready. |
SUMMARY
Currently cache warmup feature is unusable due to #9597 & #18933
This implement intend to fix it by following changes:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION