fix: ensure column name in description is string #20340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20340 +/- ##
==========================================
- Coverage 66.64% 66.48% -0.17%
==========================================
Files 1738 1738
Lines 65056 65066 +10
Branches 6885 6885
==========================================
- Hits 43356 43257 -99
- Misses 19953 20062 +109
Partials 1747 1747
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
reviewed
Jun 10, 2022
| """ | ||
| Used to ensure column names from the cursor description are strings. | ||
| """ | ||
| if isinstance(value, str): |
There was a problem hiding this comment.
Is this necessary? Isn’t the fallback suffice?
There was a problem hiding this comment.
Yeah, it's not needed, I just thought it was clearer this way.
eschutho
reviewed
Jun 14, 2022
| result_set.to_pandas_df().to_markdown() | ||
| == """ | ||
| | | date | open | high | low | close | adj close | volume | | ||
| |---:|:-----------|--------:|--------:|--------:|--------:|------------:|---------:| |
There was a problem hiding this comment.
I love it when the test is longer than the fix. :)
eschutho
approved these changes
Jun 14, 2022
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 23, 2022
* fix: ensure column name in description is string * Add unit test (cherry picked from commit f3b289d)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
* fix: ensure column name in description is string * Add unit test (cherry picked from commit f3b289d)
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
redshift_connectordriver returns column names as bytes in the cursor description. I added some logic to handle them correctly.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added a test.
ADDITIONAL INFORMATION