Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves date utils to utils folder #20192

Merged
merged 1 commit into from
May 31, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves date utils to utils folder.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20192 (6b0b3dd) into master (4674de1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #20192      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files        1722     1721       -1     
  Lines       64639    64632       -7     
  Branches     6822     6822              
==========================================
- Hits        42874    42867       -7     
  Misses      20031    20031              
  Partials     1734     1734              
Flag Coverage Δ
javascript 51.28% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <ø> (ø)
...ontend/src/SqlLab/components/QuerySearch/index.tsx 73.07% <ø> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 70.17% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <ø> (ø)
...rset-frontend/src/components/Chart/chartReducer.ts 25.00% <ø> (ø)
superset-frontend/src/components/Timer/index.tsx 78.94% <ø> (ø)
...et-frontend/src/dashboard/actions/sliceEntities.js 15.38% <0.00%> (-0.62%) ⬇️
...et-frontend/src/explore/controlPanels/Separator.js 0.00% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx 100.00% <ø> (ø)
superset-frontend/src/explore/controls.jsx 31.57% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4674de1...6b0b3dd. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 834dcef into apache:master May 31, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants