Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate-changed_on_delta_humanized #20082

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

aehanno
Copy link
Contributor

@aehanno aehanno commented May 16, 2022

SUMMARY

Using moment to calculate the lastModified value fron changed_on instead of changed_on_humanized + adding last_run

ADDITIONAL INFORMATION

Fixes #20060

…n instead of changed_on_humanized + adding last_run
@aehanno aehanno changed the title fix : Using moment to calculate the lastModified value fron changed_o… fix : translate-changed_on_delta_humanized May 16, 2022
@aehanno
Copy link
Contributor Author

aehanno commented Jun 6, 2022

Hello @villebro and @dpgaspar,
There is some problem in the translation of some delta humanized
I did a proposition of correction, @villebro tell me that it will better to handle it in backend
Do you have a proposition to implement that solution ?

@aehanno aehanno changed the title fix : translate-changed_on_delta_humanized fix: translate-changed_on_delta_humanized Jun 15, 2022
…ized' into translate-changed_on_delta_humanized
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #20082 (7d75add) into master (3f8e9a5) will increase coverage by 0.13%.
The diff coverage is 75.00%.

❗ Current head 7d75add differs from pull request most recent head af79405. Consider uploading reports for the commit af79405 to get more accurate results

@@            Coverage Diff             @@
##           master   #20082      +/-   ##
==========================================
+ Coverage   66.65%   66.79%   +0.13%     
==========================================
  Files        1793     1798       +5     
  Lines       68559    68703     +144     
  Branches     7294     7332      +38     
==========================================
+ Hits        45701    45891     +190     
+ Misses      20991    20932      -59     
- Partials     1867     1880      +13     
Flag Coverage Δ
javascript 53.15% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/components/SliceAdder.jsx 62.66% <ø> (ø)
...c/dashboard/components/dnd/AddSliceDragPreview.jsx 50.00% <ø> (ø)
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx 52.17% <ø> (ø)
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx 58.33% <ø> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 52.38% <ø> (ø)
superset/queries/saved_queries/api.py 95.28% <ø> (ø)
superset/models/sql_lab.py 76.89% <75.00%> (ø)
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx 33.33% <0.00%> (-66.67%) ⬇️
...ins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts 66.66% <0.00%> (-16.67%) ⬇️
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 5.55% <0.00%> (-11.12%) ⬇️
... and 65 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…n_delta_humanized

# Conflicts:
#	superset-frontend/src/pages/ChartList/ChartCard.tsx
#	superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
@aehanno
Copy link
Contributor Author

aehanno commented Sep 13, 2023

Hi @michael-s-molina, can you say why did you closed this PR ? Thanks

@michael-s-molina
Copy link
Member

Hi @aehanno. There hasn't been any activity in this PR since last year and it was not rebased so I thought it was a stale PR (we have many of those). If the PR is still valid, feel free to reopen it and rebase it 😉

@aehanno
Copy link
Contributor Author

aehanno commented Sep 13, 2023

@michael-s-molina I see, I was waiting for an hint for my change because I got some review first in antoher PR
Because I don't know if it's my changes are good and didn't find another way to do it

@michael-s-molina
Copy link
Member

Got it. I reopened the PR.

@rusackas
Copy link
Member

Looks like this one still needs a rebase. I won't close it yet, but I will convert it to a draft until it's ready for review. Are you still able to help us get this across the finish line, @aehanno?

@rusackas rusackas marked this pull request as draft August 20, 2024 02:49
@aehanno
Copy link
Contributor Author

aehanno commented Aug 20, 2024

Looks like this one still needs a rebase. I won't close it yet, but I will convert it to a draft until it's ready for review. Are you still able to help us get this across the finish line, @aehanno?

@rusackas If my modification are good, I can do the rebase to go forward but I'm not sure if I take the right path to correct the problem
If I can help before doing a rebase it will be appreciate unless I think we can closed it

@jbonaoned
Copy link

jbonaoned commented Dec 2, 2024

Hello, I'm coming for news. Could you tell me in which version we will have this integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing French Translation
6 participants