-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: translate-changed_on_delta_humanized #20082
base: master
Are you sure you want to change the base?
fix: translate-changed_on_delta_humanized #20082
Conversation
…n instead of changed_on_humanized + adding last_run
…n instead of changed_on_humanized + adding last_run
…ized' into translate-changed_on_delta_humanized # Conflicts: # superset-frontend/src/dashboard/components/SliceAdder.jsx
…ized' into translate-changed_on_delta_humanized
Codecov Report
@@ Coverage Diff @@
## master #20082 +/- ##
==========================================
+ Coverage 66.65% 66.79% +0.13%
==========================================
Files 1793 1798 +5
Lines 68559 68703 +144
Branches 7294 7332 +38
==========================================
+ Hits 45701 45891 +190
+ Misses 20991 20932 -59
- Partials 1867 1880 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…n_delta_humanized # Conflicts: # superset-frontend/src/pages/ChartList/ChartCard.tsx # superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
Hi @michael-s-molina, can you say why did you closed this PR ? Thanks |
Hi @aehanno. There hasn't been any activity in this PR since last year and it was not rebased so I thought it was a stale PR (we have many of those). If the PR is still valid, feel free to reopen it and rebase it 😉 |
@michael-s-molina I see, I was waiting for an hint for my change because I got some review first in antoher PR |
Got it. I reopened the PR. |
Looks like this one still needs a rebase. I won't close it yet, but I will convert it to a draft until it's ready for review. Are you still able to help us get this across the finish line, @aehanno? |
@rusackas If my modification are good, I can do the rebase to go forward but I'm not sure if I take the right path to correct the problem |
Hello, I'm coming for news. Could you tell me in which version we will have this integration? |
SUMMARY
Using moment to calculate the lastModified value fron changed_on instead of changed_on_humanized + adding last_run
ADDITIONAL INFORMATION
Fixes #20060