fix: translating variables

superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx

@@ -19,6 +19,7 @@
 
 import React from 'react';
 import PropTypes from 'prop-types';
+import { t } from '@superset-ui/core';
 import { PivotData, flatKey } from './utilities';
 import { Styles } from './Styles';
 
@@ -470,6 +471,8 @@ export class TableRenderer extends React.Component {
       i += colSpan;
     }
 
+    const constAggregatorName = `${this.props.aggregatorName}`;
+
     const totalCell =
       attrIdx === 0 && rowTotals ? (
         <th
@@ -486,7 +489,7 @@ export class TableRenderer extends React.Component {
             true,
           )}
         >
-          {`Total (${this.props.aggregatorName})`}
+          {t(`Total (%s)`, t(constAggregatorName))}
         </th>
       ) : null;
 
@@ -498,6 +501,8 @@ export class TableRenderer extends React.Component {
     // Render just the attribute names of the rows (the actual attribute values
     // will show up in the individual rows).
 
+    const constAggregatorName = `${this.props.aggregatorName}`;
+
     const {
       rowAttrs,
       colAttrs,
@@ -535,6 +540,7 @@ export class TableRenderer extends React.Component {
             </th>
           );
         })}
+
         <th
           className="pvtTotalLabel"
           key="padding"
@@ -549,7 +555,7 @@ export class TableRenderer extends React.Component {
           )}
         >
           {colAttrs.length === 0
-            ? `Total (${this.props.aggregatorName})`
+            ? t(`Total (%s)`, t(constAggregatorName))
             : null}
         </th>
       </tr>
@@ -748,6 +754,8 @@ export class TableRenderer extends React.Component {
       grandTotalCallback,
     } = pivotSettings;
 
+    const constAggregatorName = `${this.props.aggregatorName}`;
+
     const totalLabelCell = (
       <th
         key="label"
@@ -763,7 +771,7 @@ export class TableRenderer extends React.Component {
           true,
         )}
       >
-        {`Total (${this.props.aggregatorName})`}
+        {t(`Total (%s)`, t(constAggregatorName))}
       </th>
     );
 

superset-frontend/src/dashboard/components/FiltersBadge/FilterIndicator/index.tsx

@@ -19,6 +19,7 @@
 
 import { SearchOutlined } from '@ant-design/icons';
 import React, { FC } from 'react';
+import { t } from '@superset-ui/core';
 import { getFilterValueForDisplay } from 'src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils';
 import {
   FilterIndicatorText,
@@ -51,7 +52,7 @@ const FilterIndicator: FC<IndicatorProps> = ({
           {name}
           {resultValue ? ': ' : ''}
         </Title>
-        <FilterValue>{resultValue}</FilterValue>
+        <FilterValue>{t(resultValue)}</FilterValue>
       </Item>
       {text && <FilterIndicatorText>{text}</FilterIndicatorText>}
     </>

superset-frontend/src/dashboard/components/SliceAdder.jsx

@@ -318,7 +318,7 @@ class SliceAdder extends React.Component {
             value={this.state.sortBy}
             onChange={this.handleSelect}
             options={Object.entries(KEYS_TO_SORT).map(([key, label]) => ({
-              label: t('Sort by %s', label),
+              label: t('Sort by %s', t(label)),
               value: key,
             }))}
             placeholder={t('Sort by')}

superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx

@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
       <Divider />
       <div>
         <div className="section-title">{t('Actual time range')}</div>
-        {validTimeRange && <div>{evalResponse}</div>}
+        {validTimeRange && <div>{t(evalResponse)}</div>}
         {!validTimeRange && (
           <IconWrapper className="warning">
             <Icons.ErrorSolidSmall iconColor={theme.colors.error.base} />
@@ -373,7 +373,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
       >
         <Tooltip placement="top" title={tooltipTitle}>
           <Label className="pointer" data-test="time-range-trigger">
-            {actualTimeRange}
+            {t(actualTimeRange)}
           </Label>
         </Tooltip>
       </StyledPopover>

superset/translations/fr/LC_MESSAGES/messages.json

@@ -3877,7 +3877,27 @@
       ],
       "Scope": ["Périmètre"],
       "Dependent on": ["Dépend de"],
-      "No matching records found": ["Aucun résultat trouvé"]
+      "No matching records found": ["Aucun résultat trouvé"],
+      "Trend": ["Tendance"],
+      "Total (Count)": ["Total (Somme)"],
+      "Total (%s)": ["Total (%s)"],
+      "Total (Count Unique Values)": ["Total (Somme)"],
+      "Total (List Unique Values)": ["Total (Somme)"],
+      "Sum": ["Somme"],
+      "Average": ["Moyenne"],
+      "Median": ["Médiane"],
+      "Sample Variance": ["Variance échantillon"],
+      "Sample Standard Deviation": ["Écart-type échantillon"],
+      "Minimum": ["Minimum"],
+      "Maximum": ["Maximum"],
+      "First": ["Premier"],
+      "Last": ["Dernier"],
+      "Sum as Fraction of Total": ["Somme comme fraction du total"],
+      "Sum as Fraction of Rows": ["Somme comme fraction des lignes"],
+      "Sum as Fraction of Columns": ["Somme comme fraction des colonnes"],
+      "Count as Fraction of Total": ["Décompte comme fraction du total"],
+      "Count as Fraction of Rows": ["Décompte comme fraction des lignes"],
+      "Count as Fraction of Columns": ["Décompte comme fraction des colonnes"]
     }
   }
 }