Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Explore) Pre-populate dashboard in Explore #19964

Closed
wants to merge 2 commits into from

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented May 5, 2022

SUMMARY

This pre-populates the save to dashboard file if you came from an empty dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-05-06.at.4.02.47.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi marked this pull request as ready for review May 6, 2022 20:07
@AAfghahi AAfghahi changed the title feat (Explore): Pre-populate dashboard in Explore feat: (Explore) Pre-populate dashboard in Explore May 6, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 6, 2022
@AAfghahi AAfghahi force-pushed the arash/timeToDashboard branch from faec936 to ed88c67 Compare May 6, 2022 20:47
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #19964 (ed88c67) into master (902ac05) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #19964      +/-   ##
==========================================
+ Coverage   66.27%   66.29%   +0.01%     
==========================================
  Files        1712     1712              
  Lines       63957    63970      +13     
  Branches     6720     6734      +14     
==========================================
+ Hits        42390    42407      +17     
+ Misses      19859    19849      -10     
- Partials     1708     1714       +6     
Flag Coverage Δ
javascript 51.29% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/dashboard/containers/DashboardGrid.jsx 100.00% <ø> (ø)
...rontend/src/dashboard/components/DashboardGrid.jsx 63.15% <50.00%> (+0.65%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 66.23% <75.00%> (+0.03%) ⬆️
...perset-frontend/src/addSlice/AddSliceContainer.tsx 64.10% <83.33%> (+2.33%) ⬆️
...uperset-frontend/src/utils/getClientErrorObject.ts 63.15% <0.00%> (-8.28%) ⬇️
...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx 50.00% <0.00%> (-7.90%) ⬇️
superset-frontend/src/reports/actions/reports.js 36.36% <0.00%> (-3.04%) ⬇️
...-frontend/src/components/CopyToClipboard/index.jsx 96.00% <0.00%> (ø)
...frontend/src/dashboard/components/Header/index.jsx 60.92% <0.00%> (ø)
...nd/src/dashboard/components/gridComponents/Tab.jsx 83.67% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902ac05...ed88c67. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented May 11, 2022

/testenv up FEATURE_ALERT_REPORTS=True

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.89.175.233:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi
Copy link
Member Author

similar functionality added here: #20129 so closing this PR in favor of their solution.

@AAfghahi AAfghahi closed this May 20, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants