Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart & table): make to allow highlight in case of numeric column #19938

Merged
merged 3 commits into from
May 4, 2022
Merged

fix(chart & table): make to allow highlight in case of numeric column #19938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d295385
fix(chart & table): make to allow highlight in case of numeric column
prosdev0107 May 3, 2022
a941d63
fix(chart & table): make to use emitFilter directly
prosdev0107 May 3, 2022
9e6f957
fix(chart & table): make to use styled component instead of inline style
prosdev0107 May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/plugins/plugin-chart-table/src/Styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default styled.div`
cursor: pointer;
}
td.dt-is-filter:hover {
background-color: ${theme.colors.secondary.light4};
background-color: ${theme.colors.secondary.light4} !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this was working for non-integers, why do we need the important now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because table cell is using inline style when numeric cell and so I need to use important

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the inline style need to set a background color at all? If so, can we switch it to use className / Emotion?

... or the other way around, worst case.

}
td.dt-is-active-filter,
td.dt-is-active-filter:hover {
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
const getColumnConfigs = useCallback(
(column: DataColumnMeta, i: number): ColumnWithLooseAccessor<D> => {
const { key, label, isNumeric, dataType, isMetric, config = {} } = column;
const isFilter = !isNumeric && emitFilter;
const isFilter = emitFilter;
prosdev0107 marked this conversation as resolved.
Show resolved Hide resolved
const columnWidth = Number.isNaN(Number(config.columnWidth))
? config.columnWidth
: Number(config.columnWidth);
Expand Down