Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Advanced Analytics into mixed time series chart #19851

Merged
merged 12 commits into from
Apr 27, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Added Advanced Analytics into Mixed Timeseries chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

TBD

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title feat: add AA into mixed time series chart feat: add Advanced Analytics into mixed time series chart Apr 26, 2022
@zhaoyongjie zhaoyongjie marked this pull request as ready for review April 27, 2022 05:22
@zhaoyongjie zhaoyongjie requested a review from villebro April 27, 2022 05:22
Comment on lines +197 to +200
undefined,
undefined,
undefined,
undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open separated PR to remove undefined in QueryObject.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #19851 (5299fde) into master (523bd8b) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master   #19851      +/-   ##
==========================================
- Coverage   66.55%   66.49%   -0.07%     
==========================================
  Files        1692     1714      +22     
  Lines       64802    64995     +193     
  Branches     6657     6709      +52     
==========================================
+ Hits        43129    43216      +87     
- Misses      19973    20072      +99     
- Partials     1700     1707       +7     
Flag Coverage Δ
javascript 51.21% <85.71%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <0.00%> (-19.05%) ⬇️
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 100.00% <100.00%> (+100.00%) ⬆️
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 92.85% <100.00%> (+12.85%) ⬆️
...s/plugin-chart-echarts/src/utils/formDataSuffix.ts 100.00% <100.00%> (ø)
...end/src/components/Form/LabeledErrorBoundInput.tsx 95.00% <0.00%> (-5.00%) ⬇️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.07% <0.00%> (-0.28%) ⬇️
...-frontend/src/components/AlteredSliceTag/index.jsx 87.87% <0.00%> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <0.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 69.35% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523bd8b...5299fde. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass test + review: one minor problem with the period control visibility, but other than that works well.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great hack 😄 LGTM, thanks for this great improvement!

@zhaoyongjie zhaoyongjie merged commit f5e9f0e into apache:master Apr 27, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants