Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add serviceAccountName to celerybeat pods #19670

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

paulinjo
Copy link
Contributor

SUMMARY

Fixes #19669

This PR adds the serviceAccountName spec to celerybeat pods when deploying with Helm.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Set the serviceAccountName and supersetCeleryBeat.enabled:true in the values.yml file for helm deployment
  2. Deploy using Helm
  3. Observe the serviceAccountName spec on the celeryBeat pods.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@paulinjo paulinjo force-pushed the fix/add_serviceaccountname_celerybeat branch from af39d73 to ad1c292 Compare April 12, 2022 19:12
@paulinjo paulinjo force-pushed the fix/add_serviceaccountname_celerybeat branch from ad1c292 to cf4b6ce Compare April 12, 2022 23:05
@paulinjo paulinjo requested a review from craig-rueda April 20, 2022 21:29
@paulinjo paulinjo force-pushed the fix/add_serviceaccountname_celerybeat branch from 598e1ba to 624c6df Compare May 2, 2022 15:51
@dpgaspar dpgaspar closed this Jun 6, 2022
@dpgaspar dpgaspar reopened this Jun 6, 2022
@@ -22,7 +22,7 @@ maintainers:
- name: craig-rueda
email: [email protected]
url: https://github.com/craig-rueda
version: 0.6.1
version: 0.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you plz bump the version again, thank you!

@paulinjo paulinjo force-pushed the fix/add_serviceaccountname_celerybeat branch from 624c6df to 21d2e9d Compare June 6, 2022 13:39
@nytai nytai merged commit 1918dc0 into apache:master Jun 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart not adding service account name to celery beat pods
6 participants