-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Query execution time is displayed as invalid date #19605
fix: Query execution time is displayed as invalid date #19605
Conversation
/testenv up |
@yousoph Container image not yet published for this PR. Please try again when build is complete. |
@yousoph Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@yousoph Ephemeral environment spinning up at http://18.236.68.118:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #19605 +/- ##
===========================================
- Coverage 66.47% 53.92% -12.56%
===========================================
Files 1713 1713
Lines 64942 64974 +32
Branches 6690 6690
===========================================
- Hits 43171 35034 -8137
- Misses 20067 28236 +8169
Partials 1704 1704
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we should probably move away from moment. But that saddens me. An old and loyal friend.
Ephemeral environment shutdown and build artifacts deleted. |
584afe7
to
0e45ea0
Compare
0e45ea0
to
6096d14
Compare
6096d14
to
711e183
Compare
711e183
to
38808a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the following up! LGTM.
* fix: Query execution time is displayed as invalid date * PR comment * Fix test * unify response * lint (cherry picked from commit e3dbe8d)
🏷️ preset:2022.17 |
* fix: Query execution time is displayed as invalid date * PR comment * Fix test * unify response * lint
* fix: Query execution time is displayed as invalid date * PR comment * Fix test * unify response * lint
SUMMARY
The Time column in the Query History is being displayed as an Invalid date.
The reason being the underlying data type is numeric with precision, to get sub-second precision.
That means the returned json value is a string (to keep the precision) and in turn, it fails the conversion to a moment object.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Ensure the time column is displaying the proper start time.
ADDITIONAL INFORMATION