docs: Added gtag to docusaurus #19602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-github-bot
bot
added
the
Superset-Community-Partners
AAfghahi
removed
the
Superset-Community-Partners
eschutho
reviewed
Apr 8, 2022
| @@ -389,6 +389,27 @@ | |||
| json5 "^2.1.2" | |||
| semver "^6.3.0" | |||
|
|
|||
| "@babel/core@^7.17.8": | |||
There was a problem hiding this comment.
I don't see any changes to package.json. What caused this yarn.lock update?
There was a problem hiding this comment.
I added the gtag plugin to yarn. docusaurus uses yarn install instead of npm
There was a problem hiding this comment.
where did you add it to yarn? I'm pretty sure yarn uses package.json as well.
AAfghahi
force-pushed
the
ch43803_gAnalytics
branch
from
6df6d10 to
cea7148
Compare
|
@eschutho added package.json. When I was originally working on this I didn't realize that yarn added to the package, reinstalled and pushed it up. |
eschutho
approved these changes
Apr 29, 2022
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Our current google analytics tag for the docusaurus website isn't working. The docs suggested this may be the reason:
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-google-gtag
I did not delete google analytics, wanted to first see if this made a difference.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION