-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: block unsafe functions #19537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19537 +/- ##
==========================================
- Coverage 66.59% 66.40% -0.20%
==========================================
Files 1682 1682
Lines 64302 64311 +9
Branches 6554 6559 +5
==========================================
- Hits 42824 42706 -118
- Misses 19777 19904 +127
Partials 1701 1701
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
051f780
to
b4383df
Compare
b4383df
to
43141af
Compare
43141af
to
8b746d7
Compare
8b746d7
to
b9049a5
Compare
@@ -113,6 +113,6 @@ def make_url_safe(raw_url: str) -> URL: | |||
:return: | |||
""" | |||
try: | |||
return make_url(raw_url.strip()) | |||
return make_url(raw_url.strip()) # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a pretty easy way to get around this filter :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shhh, it's secret!
SUMMARY
Add pre-commit hook to disallow unsafe functions like
make_url
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION