Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enhance ReactChord style with theme vars #19517

Merged
merged 2 commits into from
Apr 7, 2022
Merged

chore: Enhance ReactChord style with theme vars #19517

merged 2 commits into from
Apr 7, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 4, 2022

SUMMARY

It enhances the ReactChord component style with theme vars.

BEFORE

DEV.Cross.Channel.Relationship.1.mp4

AFTER

DEV.Cross.Channel.Relationship.mp4

TESTING INSTRUCTIONS

  1. No observable visual changes. Opacity might be slightly different to match the theme vars.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
    q

@geido geido marked this pull request as ready for review April 4, 2022 14:52
@geido geido requested a review from michael-s-molina April 4, 2022 14:52
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a non-blocking comment.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #19517 (cb3bb66) into master (0de03c4) will decrease coverage by 0.00%.
The diff coverage is 69.36%.

❗ Current head cb3bb66 differs from pull request most recent head 40fef59. Consider uploading reports for the commit 40fef59 to get more accurate results

@@            Coverage Diff             @@
##           master   #19517      +/-   ##
==========================================
- Coverage   66.59%   66.59%   -0.01%     
==========================================
  Files        1678     1682       +4     
  Lines       64242    64294      +52     
  Branches     6539     6554      +15     
==========================================
+ Hits        42784    42817      +33     
- Misses      19763    19776      +13     
- Partials     1695     1701       +6     
Flag Coverage Δ
javascript 51.36% <67.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-chord/src/ReactChord.jsx 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...legacy-plugin-chart-sunburst/src/ReactSunburst.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <ø> (ø)
...s/legacy-plugin-chart-treemap/src/ReactTreemap.jsx 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-treemap/src/Treemap.js 0.00% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 69.23% <ø> (ø)
...end/src/explore/components/RowCountLabel/index.tsx 88.88% <ø> (ø)
superset-frontend/src/profile/App.tsx 0.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de03c4...40fef59. Read the comment docs.

@geido geido merged commit e5bab00 into apache:master Apr 7, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Enhance style with theme vars

* Update superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants