Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): clean up Python tests output #19489

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 1, 2022

SUMMARY

Currently the CI logs output a lot of useless information. Making it harder to glance through test errors. This PR changes that by:

  1. Limiting test duration report to only those are actually slow
  2. Remove codecov report in the terminal---users can check code coverage on codecov.io.

Also, the Python unittest workflow seems didn't getting codecov reported. So I added it, too.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19489 (2f18d90) into master (08aca83) will decrease coverage by 12.73%.
The diff coverage is 59.37%.

❗ Current head 2f18d90 differs from pull request most recent head d61c196. Consider uploading reports for the commit d61c196 to get more accurate results

@@             Coverage Diff             @@
##           master   #19489       +/-   ##
===========================================
- Coverage   66.39%   53.66%   -12.74%     
===========================================
  Files        1676     1677        +1     
  Lines       64211    64238       +27     
  Branches     6537     6538        +1     
===========================================
- Hits        42635    34475     -8160     
- Misses      19877    28064     +8187     
  Partials     1699     1699               
Flag Coverage Δ
mysql ?
postgres ?
presto 52.54% <ø> (?)
python 56.09% <ø> (-25.90%) ⬇️
unit 47.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugins/legacy-plugin-chart-rose/src/ReactRose.jsx 0.00% <0.00%> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx 0.00% <0.00%> (ø)
...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 0.00% <ø> (ø)
...t-deckgl/src/components/BootstrapSliderWrapper.jsx 0.00% <0.00%> (ø)
...gacy-preset-chart-deckgl/src/components/Legend.jsx 0.00% <0.00%> (ø)
...-preset-chart-deckgl/src/components/PlaySlider.jsx 0.00% <0.00%> (ø)
...uperset-ui-core/src/color/CategoricalColorScale.ts 100.00% <100.00%> (ø)
...set-ui-core/src/color/SharedLabelColorSingleton.ts 100.00% <100.00%> (ø)
...ntend/packages/superset-ui-core/src/color/utils.ts 100.00% <100.00%> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08aca83...d61c196. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review April 2, 2022 01:24
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@ktmud ktmud merged commit ea70816 into apache:master Apr 3, 2022
@john-bodley john-bodley deleted the pytests-output branch June 8, 2022 05:34
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants