fix(welcome): saved queries causing error #19464
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A recent PR #19223 caused a regression due to trying to query for
saved_query
objects by their owners, despite the model only having a creator (there is nosaved_query_user
, like there is fordashboard_user
fordashboards
andslice_user
forslices
). This renames thegetUserOwnedObjects
togetUserObjects
and adds a parameterfilterBy
which makes it possible to define whether or not to query byowners
orcreated_by
.AFTER
After the change, the welcome page loads without errors:
BEFORE
Previously there was an error toast caused by a 400:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION