Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disables no-literal-colors for the theme configuration #19437

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 30, 2022

SUMMARY

Disables no-literal-colors lint rule for the theme configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-03-30 at 11 02 20 AM

Screen Shot 2022-03-30 at 11 06 53 AM

TESTING INSTRUCTIONS

Make sure literal colors are allowed for the theme configuration.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from geido March 30, 2022 14:09
@michael-s-molina michael-s-molina changed the title chore: Disables no literal colors for the theme configuration chore: Disables no-literal-colors for the theme configuration Mar 30, 2022
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the fix!

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19437 (c28d3ab) into master (fa35109) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19437   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files        1670     1670           
  Lines       63888    63888           
  Branches     6510     6510           
=======================================
  Hits        42544    42544           
- Misses      19654    19655    +1     
+ Partials     1690     1689    -1     
Flag Coverage Δ
javascript 51.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/controls/DateFilterControl/DateFilterLabel.tsx 41.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35109...c28d3ab. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 1937448 into apache:master Mar 30, 2022
@villebro villebro added the lts-v1 label Apr 1, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
villebro pushed a commit that referenced this pull request Apr 4, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants