test(native filter): add new test for dependent filter #19392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19392 +/- ##
==========================================
+ Coverage 66.48% 66.57% +0.08%
==========================================
Files 1670 1675 +5
Lines 63952 64092 +140
Branches 6506 6519 +13
==========================================
+ Hits 42519 42669 +150
+ Misses 19747 19730 -17
- Partials 1686 1693 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stephenLYZ
reviewed
Mar 31, 2022
|
|
||
| Cypress.Commands.add('deleteDashboardByName', (name: string) => | ||
| cy.getDashboards().then(dashboards => { | ||
| for (const element of dashboards) { |
There was a problem hiding this comment.
Here may use forEach instead of for...of.
stephenLYZ
reviewed
Mar 31, 2022
|
|
||
| Cypress.Commands.add('deleteChartByName', (name: string) => | ||
| cy.getCharts().then(slices => { | ||
| for (const element of slices) { |
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* add new test for dependent filter (cherry picked from commit 2a75e4c)
villebro
pushed a commit
that referenced
this pull request
Apr 4, 2022
* add new test for dependent filter (cherry picked from commit 2a75e4c)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* add new test for dependent filter
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new test: User can create parent filters using "Values are dependent on other filters"'
SUMMARY
1, add cleanup function for native filter test to remove copy of test dashboard
2, add new test for dependent filter
Will have the command function applied to other test in a separated PR
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION