fix(dashboard-css): make to stay custom css when reload

[prosdev0107]

SUMMARY

Dashboard CSS disappears

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
The dashboard custom css is disappeared when reloaded.
AFTER:
The dashboard custom css stay when reloaded.

TESTING INSTRUCTIONS

How to reproduce the bug

1. create a dashboard
2. Edit CSS and save, for example with:

body { background-color: black; }

3.The background appears normally but when you reload the page it is not there and the CSS is gone

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[rusackas]

Unit tests seem to be failing on some styling expectation. Can you check to see if those are working locally?

[prosdev0107]

@rusackas
The unit test issue was happened because removed calling injectCustomCss from HeaderActionsDropdown.tsx.
I fixed the unit test issue of HeaderActionsDropdown.test.tsx by adding injectCustomCSS function.
I am wondering if it should has the test of rendering the custom css in HeaderActionsDropdown.test.tsx.

[codecov]

Codecov Report

Merging #19084 (e447d19) into master (c79ee56) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19084   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1645     1645           
  Lines       63494    63514   +20     
  Branches     6459     6464    +5     
=======================================
+ Hits        42230    42249   +19     
- Misses      19592    19593    +1     
  Partials     1672     1672           

Flag	Coverage Δ
javascript	51.27% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx	71.42% <ø> (-0.51%)	⬇️
...-frontend/src/dashboard/reducers/dashboardState.js	73.33% <0.00%> (-3.42%)	⬇️
...erset-frontend/src/components/EmptyState/index.tsx	61.53% <0.00%> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js	36.06% <0.00%> (+0.11%)	⬆️
superset-frontend/src/components/Chart/Chart.jsx	54.09% <0.00%> (+0.76%)	⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	64.67% <0.00%> (+1.63%)	⬆️
...veFilters/FilterBar/FilterControls/FilterValue.tsx	60.43% <0.00%> (+3.46%)	⬆️
...et-frontend/src/components/Chart/ChartRenderer.jsx	52.63% <0.00%> (+7.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79ee56...e447d19. Read the comment docs.

[rusackas]

I am wondering if it should has the test of rendering the custom css in HeaderActionsDropdown.test.tsx.

Ideally all fix:() PRs will have a good test to make sure that whatever's fixed doesn't regress again. If we can add that test in this PR to make sure styles are properly persisted, that'd be fanastic!

[prosdev0107]

@rusackas
That test was already added. I think that this PR can be approved now.

[rusackas]

Thanks for the followup. LGTM!

[sadpandajoe]

🏷️ preset:2022.11