utils: teach our json serializer to handle more types #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Jan 5, 2017
| assert json_iso_dttm_ser(t) == t.isoformat() | ||
|
|
||
| with self.assertRaises(TypeError): | ||
| json_int_dttm_ser("this is not a date") |
There was a problem hiding this comment.
gah this should be iso of course
Namely datetime.time and numpy.bool_ Refs: apache#1900 Refs: apache#1903
xrmx
force-pushed
the
moretypesjsonserializer
branch
from
bd016ef to
44dc962
Compare
3 tasks
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
Namely datetime.time and numpy.bool_ Refs: apache#1900 Refs: apache#1903
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely datetime.time and numpy.bool_. While at it add tests. The big diff on the tests are because i've run dos2unix on them