-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove logo forced width #19049
Changes from 8 commits
aa26936
67ec9bf
357df31
f777d61
ebc96cd
99c9c67
04147bf
36c5650
a4acf42
40ea796
687a26d
c588534
62e1d43
8c926f4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,7 +236,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: | |
|
||
# Specify the App icon | ||
APP_ICON = "/static/assets/images/superset-logo-horiz.png" | ||
APP_ICON_WIDTH = 126 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add something to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right! Added to the breaking changes. Thanks @michael-s-molina @rusackas let me know your thoughts about communicating this breaking change to the wider community before merging. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we do this, I think we should tag the PR with the Or, as noted elsewhere, we COULD use that value in the CSS, to make it a little more configurable. If we want to keep that complexity and avoid the breaking change, that is. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rusackas I think the configurability brings a bit of complexity to it. If there is a strong signal from the community that they need the |
||
|
||
# Specify where clicking the logo would take the user | ||
# e.g. setting it to '/' would take the user to '/superset/welcome/' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about this... 37 seems like a pretty arbitrary number. We could use the
APP_ICON_WIDTH
here, I suppose, as much as I'd like to remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with using the
APP_ICON_WIDTH
here is that it would not behave the same as it used to. I think best is not to use it or change it withAPP_ICON_MAX_WIDTH
for clarity, if that can be of any benefit to the users