fix(dashboard): incorrect chart error with slow dataset api request

[ktmud]

SUMMARY

Fix a bug where sever side chart data query errors were displayed as "No results" when the /dashboard/[id]/datasets API is slow.

Background

#15699 made loading full datasource info for Dashboard charts async, however, some chart types didn't handle incomplete datasource info properly, causing JS errors. #15993 fixed that by re-rendering the charts after the datasources are fully loaded. Then a “No results" state for dashboard chart container is introduced in

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Charts with server side errors may show as "no results":

After

Server side errors correctly rendered as unexpected errors:

TESTING INSTRUCTIONS

Here's how to reproduce the bug:

1. Go to a dashboard where the dashboard/datasets API may be slow---e.g. dashboard that used a large dataset with a lot of columns
2. Make sure users have access control error (or any other server side errors) when accessing one of the charts
3. Refresh the page until you see the datasets API returns later than the chart data api:
   

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[etr2460]

lgtm, thanks for the quick fix

[etr2460]

was this needed to fix the issue too? i'm surprised that setting the key to the id would cause a rerender since i wouldn't expect the id to ever change

[ktmud]

This is a bycatch. Just for fixing a React warning about missing key in loops.

[etr2460]

ah thanks, i didn't see a loop anywhere. does this mean the Styles above needs a key too?

[ktmud]

The loop is here: https://github.com/apache/superset/blob/157843be087f2f23a0df7c9efad8f2603150f9dc/superset-frontend/src/chart/Chart.jsx#L252

Good catch on the styled component above!

[codecov]

Codecov Report

Merging #18852 (76f2ebc) into master (0ae1ca7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #18852   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files        1633     1633           
  Lines       63210    63210           
  Branches     6409     6409           
=======================================
  Hits        41852    41852           
  Misses      19698    19698           
  Partials     1660     1660           

Flag	Coverage Δ
javascript	51.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/chart/Chart.jsx	51.78% <ø> (ø)
superset-frontend/src/chart/chartReducer.ts	25.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae1ca7...76f2ebc. Read the comment docs.