Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert handle null values in time-series table #18684

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 11, 2022

SUMMARY

#18039 caused an issue that table values are not corrected sorted in front-end. Revert it by now.

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue: fix: handle null values in time-series table #18039
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick revert!

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #18684 (d692b8b) into master (a7d505d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18684   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files        1604     1604           
  Lines       62807    62806    -1     
  Branches     6333     6333           
=======================================
  Hits        41613    41613           
+ Misses      19542    19541    -1     
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/TimeTable/TimeTable.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d505d...d692b8b. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 35684c5 into apache:master Feb 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants