-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): Implement metrics and columns popovers empty states #18681
Conversation
775a04c
to
1f4dc97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, other than that LGTM
image="empty.svg" | ||
title={ | ||
isTemporal | ||
? t('No time columns found') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: time column sounds like it refers to TIME
(hh:mm:ss) as opposed to DATE/DATETIME/TIMESTAMP.
? t('No time columns found') | |
? t('No temporal columns found') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
{isTemporal && simpleColumns.length === 0 ? ( | ||
<EmptyStateSmall | ||
image="empty.svg" | ||
title={t('No time columns found')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
1f4dc97
to
44c8b1d
Compare
Codecov Report
@@ Coverage Diff @@
## master #18681 +/- ##
==========================================
+ Coverage 66.32% 66.33% +0.01%
==========================================
Files 1619 1619
Lines 62939 62946 +7
Branches 6341 6347 +6
==========================================
+ Hits 41742 41755 +13
+ Misses 19545 19537 -8
- Partials 1652 1654 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
This PR implements chart empty states for 4 scenarios:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc
https://app.shortcut.com/preset/story/36403/explore-empty-states