fix: new alert should have force_screenshot be true #18182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18182 +/- ##
==========================================
+ Coverage 66.04% 66.27% +0.23%
==========================================
Files 1591 1594 +3
Lines 62409 62485 +76
Branches 6283 6312 +29
==========================================
+ Hits 41221 41415 +194
+ Misses 19567 19421 -146
- Partials 1621 1649 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
ping @betodealmeida and @eschutho for code review. thanks! |
ktmud
reviewed
Feb 2, 2022
| const data: any = { | ||
| ...currentAlert, | ||
| type: isReport ? 'Report' : 'Alert', | ||
| force_screenshot: forceScreenshot ? 'true' : 'false', | ||
| force_screenshot: | ||
| shouldEnableForceScreenshot || forceScreenshot ? 'true' : 'false', |
There was a problem hiding this comment.
Can we change this to boolean and update line 520 to const data: AlertObject while we are here?
There was a problem hiding this comment.
i fixed force_screenshot to be boolean type. But data is not AlertObject, see line 553 ~ 559, it is temporary object carried a lot of extra fields.
ktmud
approved these changes
Feb 2, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix: new alert should have force_screenshot be true * fix comments
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
* fix: new alert should have force_screenshot be true * fix comments
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix: new alert should have force_screenshot be true * fix comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
From feature #17853, when a chart alert condition is matched, Superset will do force_refresh query and generate a screenshot. We also had db migration to set all chart alerts' force_refresh attribute be true.
But when user create new chart alert, its force_refresh is false. This PR is to fix this issue, and set force_refresh default be true when creating new chart alert.
TESTING INSTRUCTIONS
CI and manual test:
force_refreshvalue from report_scedule table.ADDITIONAL INFORMATION