Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): apply default value correctly when it's set #17982

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix(native-filters): apply default value correctly when it's set #17982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions superset-frontend/src/dataMask/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function getInitialDataMask(
} as DataMaskWithId;
}

async function fillNativeFilters(
function fillNativeFilters(
filterConfig: FilterConfiguration,
mergedDataMask: DataMaskStateWithId,
draftDataMask: DataMaskStateWithId,
Expand Down Expand Up @@ -139,8 +139,6 @@ const dataMaskReducer = produce(
action.filterConfig ?? [],
cleanState,
draft,
// @ts-ignore
action.data.dataMask,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the same issue on line 134?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in line 134 action object does have data.dataMask field.

action.filters,
);
return cleanState;
Expand Down