-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to use configured Service Account Name for init job. #17888
Add possibility to use configured Service Account Name for init job. #17888
Conversation
Hi @craig-rueda! Could you please review? |
Hey @wiktor2200, Sure I have just quickly looked at your PR so it looks nice, I will have maybe 1/2 suggestions so if you are OK, let's merge the changes? :) |
Ok, so I will add your changes to my PR. Sure feel free to add your suggestions, all feedback is welcome :) |
after this one: #17886 is merged. so rebase from master and get that fix in |
@@ -31,6 +31,9 @@ spec: | |||
{{ toYaml .Values.init.podAnnotations | nindent 8 }} | |||
{{- end }} | |||
spec: | |||
{{- if .Values.serviceAccountName }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a default value, with a comment around it in the values.yaml
?
I can see that @wiktor2200 got his PR #17880 merged so I will close this one. Thanks a lot for review! |
Thanks a lot for help and co-op! |
SUMMARY
Possibility to use Service Account Name by init-job.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
helm install superset .
ADDITIONAL INFORMATION