Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): don't apply time range filter to Samples table #17711

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 10, 2021

SUMMARY

Samples table shouldn't depend on filters set by the user. This request removes time range filter from samples query object, so that user can browse samples even when selected time range doesn't match the records.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Create a chart with specified time range
  2. Verify that samples table is not affected by time range

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @jinghua-qa

https://app.shortcut.com/preset/story/33425/time-range-filter-is-being-applied-to-samples-request-on-explore

@kgabryje kgabryje force-pushed the fix/samples-time-range branch from b984302 to fbfb8aa Compare December 10, 2021 12:13
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #17711 (d1271db) into master (8e69b2d) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head d1271db differs from pull request most recent head fbfb8aa. Consider uploading reports for the commit fbfb8aa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17711      +/-   ##
==========================================
- Coverage   68.13%   67.95%   -0.19%     
==========================================
  Files        1653     1653              
  Lines       66375    66377       +2     
  Branches     7120     7120              
==========================================
- Hits        45226    45107     -119     
- Misses      19252    19373     +121     
  Partials     1897     1897              
Flag Coverage Δ
hive ?
mysql 82.19% <100.00%> (+<0.01%) ⬆️
postgres 82.20% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.29% <100.00%> (-0.41%) ⬇️
sqlite 81.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 58.13% <ø> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 76.92% <100.00%> (ø)
superset/common/query_actions.py 93.05% <100.00%> (+0.19%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e69b2d...fbfb8aa. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit b5b6ceb into apache:master Dec 10, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants