Make cell-click filter in table viz optional #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added table_filter checkbox in table viz - If set to false, clicking on a cell in table will not apply filter to dashboard
mistercrunch
reviewed
Dec 5, 2016
| @@ -784,6 +784,12 @@ def __init__(self, viz): | |||
| "description": _( | |||
| "Whether to include a client side search box") | |||
| }), | |||
| 'table_filter': (BetterBooleanField, { | |||
| "label": _("Table Filter"), | |||
| "default": True, | |||
There was a problem hiding this comment.
Let's put the default to False.
mistercrunch
reviewed
Dec 5, 2016
| table_filter: { | ||
| type: 'CheckboxField', | ||
| label: 'Table Filter', | ||
| default: true, |
There was a problem hiding this comment.
Let's put the default to False.
|
LGTM |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1752
Done:
dashboard
needs-review @ascott @mistercrunch @bkyryliuk