Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate EstimateQueryCostButton component from jsx to tsx #17603

Merged
merged 5 commits into from
Dec 1, 2021
Merged

chore: migrate EstimateQueryCostButton component from jsx to tsx #17603

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d472de
migrate EstimateQueryCostButton component from jsx to tsx
Damans227 Nov 30, 2021
d25bdbf
re-format spaces using prettier
Damans227 Nov 30, 2021
511b4b8
Update superset-frontend/src/SqlLab/components/EstimateQueryCostButto…
Damans227 Dec 1, 2021
eca9815
remove extra onClick and make disabled prop optional
Damans227 Dec 1, 2021
853cae2
restore & rename event handler onClick to onClickHandler
Damans227 Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions ...ponents/EstimateQueryCostButton/index.jsx → ...ponents/EstimateQueryCostButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
* under the License.
*/
import React, { useMemo } from 'react';
import PropTypes from 'prop-types';
import Alert from 'src/components/Alert';
import { t } from '@superset-ui/core';
import TableView from 'src/components/TableView';
Expand All @@ -26,24 +25,28 @@ import Loading from 'src/components/Loading';
import ModalTrigger from 'src/components/ModalTrigger';
import { EmptyWrapperType } from 'src/components/TableView/TableView';

const propTypes = {
dbId: PropTypes.number.isRequired,
schema: PropTypes.string.isRequired,
sql: PropTypes.string.isRequired,
getEstimate: PropTypes.func.isRequired,
queryCostEstimate: PropTypes.Object,
selectedText: PropTypes.string,
tooltip: PropTypes.string,
disabled: PropTypes.bool,
};
const defaultProps = {
queryCostEstimate: [],
tooltip: '',
disabled: false,
};
interface EstimateQueryCostButtonProps {
dbId: number;
schema: string;
sql: string;
getEstimate: Function;
queryCostEstimate: Record<string, any>;
Damans227 marked this conversation as resolved.
Show resolved Hide resolved
selectedText?: string;
tooltip?: string;
disabled?: boolean;
}

const EstimateQueryCostButton = props => {
const { cost } = props.queryCostEstimate;
const EstimateQueryCostButton = ({
dbId,
schema,
sql,
getEstimate,
queryCostEstimate = {},
selectedText,
tooltip = '',
disabled = false,
}: EstimateQueryCostButtonProps) => {
const { cost } = queryCostEstimate;
const tableData = useMemo(() => (Array.isArray(cost) ? cost : []), [cost]);
const columns = useMemo(
() =>
Expand All @@ -53,21 +56,23 @@ const EstimateQueryCostButton = props => {
[cost],
);

const onClick = () => {
props.getEstimate();
// A call back method to pass an event handler function as a prop to the Button element.
// Refer: https://reactjs.org/docs/handling-events.html
const onClickHandler = () => {
getEstimate();
};

const renderModalBody = () => {
if (props.queryCostEstimate.error !== null) {
if (queryCostEstimate.error !== null) {
return (
<Alert
key="query-estimate-error"
type="error"
message={props.queryCostEstimate.error}
message={queryCostEstimate.error}
/>
);
}
if (props.queryCostEstimate.completed) {
if (queryCostEstimate.completed) {
return (
<TableView
columns={columns}
Expand All @@ -81,7 +86,6 @@ const EstimateQueryCostButton = props => {
return <Loading position="normal" />;
};

const { disabled, selectedText, tooltip } = props;
const btnText = selectedText
? t('Estimate selected query cost')
: t('Estimate cost');
Expand All @@ -93,7 +97,7 @@ const EstimateQueryCostButton = props => {
triggerNode={
<Button
style={{ height: 32, padding: '4px 15px' }}
onClick={onClick}
onClick={onClickHandler}
key="query-estimate-btn"
tooltip={tooltip}
disabled={disabled}
Expand All @@ -106,7 +110,4 @@ const EstimateQueryCostButton = props => {
);
};

EstimateQueryCostButton.propTypes = propTypes;
EstimateQueryCostButton.defaultProps = defaultProps;

export default EstimateQueryCostButton;