Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix deprecated unittest aliases for Python 3.11 compatibility. #17562

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

tirkarthi
Copy link
Contributor

SUMMARY

Fix deprecated unittest aliases for Python 3.11 compatibility. The deprecated aliases have been removed in python/cpython#28268 in Python 3.11. Similar to #10195

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the first Python 3.11 support PR! 🎉

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #17562 (607b845) into master (870d2ab) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17562      +/-   ##
==========================================
+ Coverage   76.81%   77.02%   +0.21%     
==========================================
  Files        1049     1049              
  Lines       56671    56682      +11     
  Branches     7851     7851              
==========================================
+ Hits        43529    43660     +131     
+ Misses      12889    12769     -120     
  Partials      253      253              
Flag Coverage Δ
hive 81.61% <ø> (?)
mysql 82.03% <ø> (+<0.01%) ⬆️
postgres 82.04% <ø> (+<0.01%) ⬆️
presto 81.91% <ø> (?)
python 82.53% <ø> (+0.41%) ⬆️
sqlite 81.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/core.py 89.76% <0.00%> (+0.11%) ⬆️
superset/db_engine_specs/base.py 88.54% <0.00%> (+0.38%) ⬆️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.57%) ⬆️
superset/views/database/mixins.py 82.75% <0.00%> (+1.72%) ⬆️
superset/db_engine_specs/trino.py 63.85% <0.00%> (+4.13%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.88%) ⬆️
superset/db_engine_specs/hive.py 87.25% <0.00%> (+16.98%) ⬆️
superset/db_engines/hive.py 85.18% <0.00%> (+85.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870d2ab...607b845. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 26, 2021
@tirkarthi
Copy link
Contributor Author

It seems the pip packages are not cached which causes the install step to download always from PyPI. I have added caching as per docs in https://github.com/actions/setup-python#caching-packages-dependencies

@villebro villebro merged commit 11cf15f into apache:master Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants