Create users if not found. #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Dec 5, 2016
| username=user_data['username'], | ||
| first_name=user_data['username'], | ||
| last_name=user_data['username'], | ||
| email=user_data['username'], |
There was a problem hiding this comment.
typo :) will improve the unit test
ascott
reviewed
Dec 5, 2016
| 'usernames': ['gamma'], | ||
| 'users': [{ | ||
| 'username': 'gamma', | ||
| 'email': '[email protected]' |
There was a problem hiding this comment.
i'm guessing this email won't actually get used to send email, but should we use the airbnb domain instead just in case it does and superset.com has a catchall email address setup? looks like a parked domain currently.
could use [email protected]
There was a problem hiding this comment.
I've added the email field, actually we plan to send emails for the access requests )
ascott
reviewed
Dec 5, 2016
| if not user and user_data['username']: | ||
| sm.add_user( | ||
| username=user_data['username'], | ||
| first_name=user_data['username'], |
There was a problem hiding this comment.
does user_data have a first/last name available?
There was a problem hiding this comment.
good point, I'll do it more generic, we do not have the data.
|
probably want @mistercrunch do take a quick look, but LGTM! |
|
LGTM |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to pre-create and preassign users to the groups before they login to the superset. It will allow users to have full access once they are logged in to the tool.
Reviewers: