Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(QueryObject): decouple from queryContext and clean code #17465

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Nov 17, 2021

Background

When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest.
All chartData flows and its components are too couple to superset so it is impossible to create unittests.
The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty

So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow

This is the seventh PR in a sequence of PRs to meet these
The next PR is #17466

PR description

as written, decouple QueryObject from its parent and some clean code (method extractions)

Test plans

There are no logic changes, so new tests are not required

Previous PRs

  1. refactor(ChartData): move ChartDataResult enums to common #17399
  2. refactor(ChartData): move chart_data_apis from ChartRestApi ChartDataRestApi #17400
  3. refactor(ChartDataCommand): separate loading query_context form cache into different module #17405
  4. refactor(TestChartApi): move chart data api tests into TestChartDataApi #17407
  5. refactor(ChartDataCommand): into two separate commands #17425
  6. refactor(ChartDataCommand): remove create queryContext command's responsibly  #17461

@ofekisr ofekisr force-pushed the refactor/chart_data_flows7 branch from ab5e8e9 to 31e521b Compare November 17, 2021 16:32
@ofekisr ofekisr changed the title refactor(QueryObject) - decouple from queryContext and clean code refactor(QueryObject): decouple from queryContext and clean code Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #17465 (717277e) into master (3f2129b) will increase coverage by 0.00%.
The diff coverage is 98.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17465   +/-   ##
=======================================
  Coverage   76.94%   76.95%           
=======================================
  Files        1042     1042           
  Lines       56312    56331   +19     
  Branches     7793     7793           
=======================================
+ Hits        43329    43348   +19     
  Misses      12727    12727           
  Partials      256      256           
Flag Coverage Δ
hive 81.53% <98.21%> (+0.01%) ⬆️
mysql 81.95% <98.21%> (+0.01%) ⬆️
postgres 81.96% <98.21%> (+0.01%) ⬆️
presto 81.83% <98.21%> (+0.01%) ⬆️
python 82.46% <98.21%> (+0.01%) ⬆️
sqlite 81.64% <98.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_object.py 93.61% <98.03%> (+0.71%) ⬆️
superset/common/query_context.py 91.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2129b...717277e. Read the comment docs.

@ofekisr ofekisr force-pushed the refactor/chart_data_flows7 branch from 31e521b to 717277e Compare November 18, 2021 10:48
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants