-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reports code clean 10-29 #17424
Merged
eschutho
merged 4 commits into
apache:refactorReports
from
preset-io:lyndsi/codeClean1029
Nov 19, 2021
Merged
refactor: Reports code clean 10-29 #17424
eschutho
merged 4 commits into
apache:refactorReports
from
preset-io:lyndsi/codeClean1029
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Comment on lines
+167
to
+170
// state.users.filter(item => item.id !== action.payload) | ||
// return { | ||
// ...state.filter(report => report.id !== action.reportId), | ||
// }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// state.users.filter(item => item.id !== action.payload) | |
// return { | |
// ...state.filter(report => report.id !== action.reportId), | |
// }; |
eschutho
pushed a commit
that referenced
this pull request
Nov 24, 2021
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
eschutho
added a commit
that referenced
this pull request
Nov 29, 2021
* pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * added report state Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]>
eschutho
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
added a commit
that referenced
this pull request
Mar 11, 2022
* pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
AAfghahi
pushed a commit
that referenced
this pull request
Mar 22, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
added a commit
that referenced
this pull request
Mar 22, 2022
* pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
AAfghahi
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
added a commit
that referenced
this pull request
Apr 18, 2022
* pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
AAfghahi
pushed a commit
to preset-io/superset
that referenced
this pull request
May 9, 2022
* Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log
AAfghahi
added a commit
to preset-io/superset
that referenced
this pull request
May 9, 2022
* pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
AAfghahi
added a commit
that referenced
this pull request
May 11, 2022
* bumping shillelagh * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * Preset io ch28954 refactor reports (#19129) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> * deleted additional folder * fixing tests * all but styling * bumping shillelagh * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * Preset io ch28954 refactor reports (#19129) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Arash/new state report (#16987) * code dry (#16358) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor(reports): Arash/refactor reports (#16855) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (#16872) * pexdax refactor (#16333) * refactor progress (#16339) * fix: Header Actions test refactor (#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (#16358) * Fetch bug fixed (#16376) * continued refactoring (#16377) * refactor: Reports - ReportModal (#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) * Add functionality is now working (#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> * deleted additional folder * fixing tests * all but styling * fixed tests Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* bumping shillelagh * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * Preset io ch28954 refactor reports (apache#19129) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> * deleted additional folder * fixing tests * all but styling * bumping shillelagh * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * Preset io ch28954 refactor reports (apache#19129) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Arash/new state report (apache#16987) * code dry (apache#16358) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor(reports): Arash/refactor reports (apache#16855) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * report pickup Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor(reports): Arash/again refactor reports (apache#16872) * pexdax refactor (apache#16333) * refactor progress (apache#16339) * fix: Header Actions test refactor (apache#16336) * fixed tests * Update index.tsx Co-authored-by: Elizabeth Thompson <[email protected]> * code dry (apache#16358) * Fetch bug fixed (apache#16376) * continued refactoring (apache#16377) * refactor: Reports - ReportModal (apache#16622) * refactoring progress * removed consoles * Working, but with 2 fetches * it is still not working Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * next changes Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> * refactor: Reports code clean 10-29 (apache#17424) * Add delete functionality * Report schema restructure progress * Fix lint * Removed console.log * fix(Explore): Remove changes to the properties on cancel (apache#17184) * Remove on close * Fix lint * Add tests * fix(dashboard): don't show report modal for anonymous user (apache#17106) * Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <[email protected]> * fix(explore): Metric control breaks when saved metric deleted from dataset (apache#17503) * Add functionality is now working (apache#17578) * refactoring reports * ready for review * added testing * removed user reducer * elizabeth suggestions Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> * deleted additional folder * fixing tests * all but styling * fixed tests Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Elizabeth and I paired to come up with this solution for cleaning up the state racing issue. This should work, the actions/modal just need to be lined up with the new state structure:
ADDITIONAL INFORMATION