Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump FAB to 3.4.0 #17420

Merged
merged 1 commit into from
Nov 19, 2021
Merged

chore: Bump FAB to 3.4.0 #17420

merged 1 commit into from
Nov 19, 2021

Conversation

kamalkeshavani-aiinside
Copy link
Contributor

@kamalkeshavani-aiinside kamalkeshavani-aiinside commented Nov 12, 2021

Bumping FAB to latest 3.4.0
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #17420 (c6291dd) into master (ffa55f7) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17420      +/-   ##
==========================================
- Coverage   77.01%   76.80%   -0.22%     
==========================================
  Files        1040     1040              
  Lines       56077    56077              
  Branches     7738     7738              
==========================================
- Hits        43190    43069     -121     
- Misses      12629    12750     +121     
  Partials      258      258              
Flag Coverage Δ
hive ?
mysql 81.89% <ø> (ø)
postgres 81.90% <ø> (ø)
presto ?
python 81.98% <ø> (-0.42%) ⬇️
sqlite 81.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.49% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.35% <0.00%> (-1.62%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.98% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa55f7...c6291dd. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@kamalkeshavani-aiinside
Copy link
Contributor Author

@junlincc Please tag this for v1.4

@villebro
Copy link
Member

villebro commented Nov 19, 2021

@kamalkeshavani-aiinside FYI I updated the description to link to the PRs on the FAB GH repo (previously the numbered tags were pointing to issues on this repo)

@dpgaspar dpgaspar merged commit 02a9b84 into apache:master Nov 19, 2021
@usamaB
Copy link

usamaB commented Dec 6, 2021

I tried the 1.4.0rc1 but the login/logout flow hasn't been fixed. I'm unable to logout. It just automatically logs in and brings me to the welcome screen. And the login flow is incorrect as well. If you have a single provider it doesn't show login UI but takes directly to enter email/pass UI(google in my case).

And if I do grep for Flask-AppBuilder in the pod shell(I'm using helm) it shows it has v3.3.0 and not v.3.4.0.

@dpgaspar
Copy link
Member

dpgaspar commented Dec 9, 2021

@usamaB with FAB 3.3.0 that behaviour is expected, have you rebuilt your container with this commit included?

@eschutho eschutho added the v1.4 label Jan 5, 2022
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
Bumping FAB to latest 3.4.0
eschutho pushed a commit that referenced this pull request Jan 12, 2022
Bumping FAB to latest 3.4.0

(cherry picked from commit 02a9b84)
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants