-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump FAB to 3.4.0 #17420
chore: Bump FAB to 3.4.0 #17420
Conversation
Bumping FAB to latest 3.4.0
Codecov Report
@@ Coverage Diff @@
## master #17420 +/- ##
==========================================
- Coverage 77.01% 76.80% -0.22%
==========================================
Files 1040 1040
Lines 56077 56077
Branches 7738 7738
==========================================
- Hits 43190 43069 -121
- Misses 12629 12750 +121
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
@junlincc Please tag this for v1.4 |
@kamalkeshavani-aiinside FYI I updated the description to link to the PRs on the FAB GH repo (previously the numbered tags were pointing to issues on this repo) |
I tried the 1.4.0rc1 but the login/logout flow hasn't been fixed. I'm unable to logout. It just automatically logs in and brings me to the welcome screen. And the login flow is incorrect as well. If you have a single provider it doesn't show login UI but takes directly to enter email/pass UI(google in my case). And if I do grep for Flask-AppBuilder in the pod shell(I'm using helm) it shows it has v3.3.0 and not v.3.4.0. |
@usamaB with FAB 3.3.0 that behaviour is expected, have you rebuilt your container with this commit included? |
Bumping FAB to latest 3.4.0 (cherry picked from commit 02a9b84)
SUMMARY
Bumping FAB to latest 3.4.0
Changes: