test: add native filter default value e2e #17398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinghua-qa
changed the title
jinghua-qa
changed the title
jinghua-qa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #17398 +/- ##
==========================================
- Coverage 77.02% 76.91% -0.12%
==========================================
Files 1038 1039 +1
Lines 56021 56153 +132
Branches 7735 7785 +50
==========================================
+ Hits 43150 43189 +39
- Misses 12613 12706 +93
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geido
reviewed
Nov 11, 2021
| .find(nativeFilters.filtersPanel.filterName) | ||
| .click() | ||
| .type('country_name'); | ||
| cy.get('.loading inline-centered css-101mkpk').should('not.exist'); |
There was a problem hiding this comment.
I think this might need to be like the following instead? Also, I would avoid pointing to generated classes like this one if possible css-101mkpk
Suggested change
| cy.get('.loading inline-centered css-101mkpk').should('not.exist'); | |
| cy.get('.loading .inline-centered .css-101mkpk').should('not.exist'); |
There was a problem hiding this comment.
I also think it is not necessary to check the generated classes, remove that line
jinghua-qa
force-pushed
the
add_nativefilter_part4
branch
from
27f823e to
be5e027
Compare
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* add native filter default value e2e test * fix lint * remove unnecessary check
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
add native filter default value e2e test: User can check 'Filter has default value
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION